Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factorizations should probably not define conversion methods to arrays and vice versa #1096

Open
KristofferC opened this issue Oct 10, 2024 · 0 comments
Open

Factorizations should probably not define conversion methods to arrays and vice versa #1096

KristofferC opened this issue Oct 10, 2024 · 0 comments
Labels
minor change Marginal behavior change acceptable for a minor release needs pkgeval Tests for all registered packages should be run with this change

Comments

@KristofferC
Copy link
Member

These should probably just be removed

https://github.com/JuliaLang/julia/blob/84a2458e0504d92b3db32bb367e449377c802593/stdlib/LinearAlgebra/src/factorization.jl#L102-L104

convert should be defined quite sparingly and these are different things.
@KristofferC KristofferC added minor change Marginal behavior change acceptable for a minor release needs pkgeval Tests for all registered packages should be run with this change labels Oct 10, 2024
@KristofferC KristofferC transferred this issue from JuliaLang/julia Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
minor change Marginal behavior change acceptable for a minor release needs pkgeval Tests for all registered packages should be run with this change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KristofferC