Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regressions in linear algebra benchmarks with Hermitian and Triangular matrices #1077

Open
Zentrik opened this issue Jun 14, 2024 · 0 comments
Labels
performance Must go faster regression Regression in behavior compared to a previous version

Comments

@Zentrik
Copy link
Member

Zentrik commented Jun 14, 2024

I haven't been able to replicate locally so can't bisect. But the regression is persistent on NanoSoldier so likely real.
The bad commit should be one of these ones, JuliaLang/julia@16d70b5...b8e714d.

You can find the benchmark data at https://tealquaternion.camdvr.org/compare.html?name=%28Hermitian%7CTriangular%29&regex=true&start=16d70b53f3e2493310b1bca61b3dcc861284a248&stat=min-wall-time&end=b8e714dfa3d81edd56ccda853322b6e42d94cf60 and below.
These are the min wall time results,

Summary

Range Mean Count
Regressions 3.24%, 78.76% 34.89% 11

Benchmarks

Benchmark % Change Significance Factor
linalg.arithmetic.(exp, typename(LinearAlgebra.Hermitian), 1024) 78.76% 72.72x
linalg.arithmetic.(log, typename(LinearAlgebra.Hermitian), 1024) 78.24% 46.84x
linalg.arithmetic.(sqrt, typename(LinearAlgebra.Hermitian), 1024) 77.74% 48.91x
linalg.arithmetic.(*, typename(LinearAlgebra.UpperTriangular), Vector, 1024) 27.45% 1.21x
linalg.arithmetic.(sqrt, typename(LinearAlgebra.Hermitian), 256) 27.23% 74.58x
linalg.arithmetic.(exp, typename(LinearAlgebra.Hermitian), 256) 27.19% 66.60x
linalg.arithmetic.(log, typename(LinearAlgebra.Hermitian), 256) 27.02% 95.91x
linalg.arithmetic.(\, typename(LinearAlgebra.UpperTriangular), Vector, 1024) 25.86% 1.39x
linalg.arithmetic.(\, typename(LinearAlgebra.LowerTriangular), Vector, 256) 5.82% 1.71x
linalg.arithmetic.(\, typename(LinearAlgebra.UpperTriangular), Vector, 256) 5.22% 1.05x
linalg.arithmetic.(*, typename(LinearAlgebra.LowerTriangular), Vector, 256) 3.24% 1.52x
@dkarrasch dkarrasch added performance Must go faster regression Regression in behavior compared to a previous version labels Jun 15, 2024
@KristofferC KristofferC transferred this issue from JuliaLang/julia Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Must go faster regression Regression in behavior compared to a previous version
Projects
None yet
Development

No branches or pull requests

2 participants