Various AST cleanups related to removing invisible tokens #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`return` can have zero arguments - indicate this with empty children, rather than with an invisible `K"nothing"` token.
c42f
changed the title
Codecov Report
@@ Coverage Diff @@
## main #220 +/- ##
==========================================
- Coverage 96.32% 96.30% -0.03%
==========================================
Files 15 15
Lines 3863 3869 +6
==========================================
+ Hits 3721 3726 +5
- Misses 142 143 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
c42f
force-pushed
the
c42f/bump-invisible-cleanup
branch
from
e731be2 to
0da52d3
Compare
This allows us to easily distinguish juxtaposition syntax from explicit multiplication.
c42f
force-pushed
the
c42f/bump-invisible-cleanup
branch
from
0da52d3 to
805e2c8
Compare
Various AST cleanups: * `struct` and `mutable struct` are distinguished with flags not children * `module` and `baremodule` are distinguished with flags not children * `return` now parses with empty children rather than with an invisible K"nothing" as the only child.
c42f
force-pushed
the
c42f/bump-invisible-cleanup
branch
from
805e2c8 to
9eb28b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
juxtaposition syntax from explicit multiplication.
structandmutable structare distinguished with flags not childrenmoduleandbaremoduleare distinguished with flags not childrenreturnnow parses with empty children rather than with an invisibleK"nothing"as the only child.Fixes most of #219