Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Expr comparison code for registry testing #175

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

c42f
Copy link
Member

@c42f c42f commented Dec 19, 2022

Add special cases to explicitly allow a few incompatibilities for cases where the reference parser has bugs:

  • 0x1.8p23f is a Float64 literal, with the trailing f ignored (also 0x1p1f0)
  • The macrocall in "@f(a=1) do\nend" is not the same as the call in @f(a=1)
  • global (x,y) is the same as global x,y
  • Triple quoted indentation - "\"\"\"\n a\n \n b\"\"\"" parses to "a\n \nb"

Tooling for #134

Add special cases to explicitly allow a few incompatibilities for cases
where the reference parser has bugs:

* `0x1.8p23f` is a `Float64` literal, with the trailing `f` ignored (also `0x1p1f0`)
* The macrocall in `"@f(a=1) do\nend"` is not the same as the call in `@f(a=1)`
* `global (x,y)` is the same as `global x,y`
* Triple quoted indentation - `"\"\"\"\n  a\n \n  b\"\"\""` parses to "a\n \nb"
@c42f c42f merged commit 5ee03f2 into main Dec 20, 2022
@c42f c42f deleted the c42f/expr-conversion-compat branch December 20, 2022 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant