-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package options #38
Comments
The lack of a good way to do this is starting to be a serious problem. Right now, e.g. PyCall and Conda save preferences (like which python version to use) in the I could install the preferences into @StefanKarpinski and @KristofferC, do you have any ideas about where persistent preferences should be stored? |
@StefanKarpinski has an idea written out here: JuliaLang/Pkg.jl#458 (comment) |
That explicitly deals with only project-specific configuration. I disagree with Stefan that package-specific configuration is unneeded. If the user installs PyCall, how do they specify the Python version in a way that will be remembered across updates? Asking them to create a project just to do this seems like a nonstarter. It seems like there needs to be way to store package options persistently in a given environment, perhaps in a way that is inherited by projects created within that environment. |
I never said that package-specific configuration was not needed. I have said that package configuration must be a global property controlled by an application or global environment, not by other packages since packages are reusable. |
well, you could allow it in packages, but let the projects have primacy. |
That means that packages will get tested one way but run a different way. Seems like a bad idea. |
I was just envisioning the package-provided one to be the "default" (though of course, that logic could be handled in the Pkg.build as well). We should provide a way to override these at the command line or via environment variables, so that it is easy to set up a test matrix. |
So I am clear, That is 5 environment variables, and it is about to get a 6th to control how often download progress is displayed. These things are configurable at run time. I know C# and Java include built in configuration libraries. |
As a stopgap until we get proper package options (JuliaLang/Juleps#38), store PYTHON preference in depot_path/prefs/PyCall so that they aren't forgotten when PyCall is updated
As a stopgap until we get proper package options (JuliaLang/Juleps#38), store JUPYTER preference in depot_path/prefs/IJulia so that it isn't forgotten when IJulia is updated. See also JuliaPy/PyCall.jl#589
As a stopgap until we get proper package options (JuliaLang/Juleps#38), store JULIA_FFTW_PROVIDER preference in depot_path/prefs/FFTW so that it isn't forgotten when FFTW.jl is updated. See also JuliaPy/PyCall.jl#589
* store prefs in depot_path/prefs As a stopgap until we get proper package options (JuliaLang/Juleps#38), store JULIA_FFTW_PROVIDER preference in depot_path/prefs/FFTW so that it isn't forgotten when FFTW.jl is updated. See also JuliaPy/PyCall.jl#589 * whoops, forgot mkpath
* store prefs in depot_path/prefs As a stopgap until we get proper package options (JuliaLang/Juleps#38), store JUPYTER preference in depot_path/prefs/IJulia so that it isn't forgotten when IJulia is updated. See also JuliaPy/PyCall.jl#589 * misplaced const
* store prefs in depot_path/prefs As a stopgap until we get proper package options (JuliaLang/Juleps#38), store PYTHON preference in depot_path/prefs/PyCall so that they aren't forgotten when PyCall is updated * whoops
Given that JuliaLang/julia#37595 is merged and we (will) have https://github.com/JuliaPackaging/Preferences.jl, I think we can close it now? |
It would be nice to have uniform way to specify package configuration options. Currently, I'm using environment variables for this (e.g. PYTHON in PyCall), but that is somewhat non-Julian. More importantly, it requires some manual effort for me to save the option in a file so that it is "remembered" when you do
Pkg.update
etcetera even if the environment variable is no longer set. Many packages will get this wrong, and even if they get it right it is a lot of duplication of effort.My suggestion would be that the package TOML file should have something like:
The user interface would be something like:
Pkg.option("PyCall", :python)
— return the current choice (saved in a file somewhere)Pkg.option("PyCall", python="python2")
— change the option, maybe rebuilding automatically unless this is called by the package during the buildPkg.add
andPkg.build
will acceptpython="python2"
keyword arguments to set options when installing/building.The value of all options would be saved in an
options.toml
file somewhere.A related mechanism would be used for package alternatives, see #37.
The text was updated successfully, but these errors were encountered: