Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allequal(f, itr) and allunique(f, itr) #818

Merged
merged 6 commits into from
Feb 19, 2024

Conversation

mcabbott
Copy link
Contributor

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9e88843) 92.37% compared to head (295af03) 92.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #818      +/-   ##
==========================================
+ Coverage   92.37%   92.65%   +0.28%     
==========================================
  Files           2        2              
  Lines         341      354      +13     
==========================================
+ Hits          315      328      +13     
  Misses         26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@martinholters martinholters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @test_skips are a bit unfortunate, but the documentation in Base allows this ("The precise number of calls is regarded as an implementation detail."), so ok.

But this reminds me of #814. We would be better off if we had defined unexported Compat.allequal and Compat.allunique. Then we could just keep rolling our own here, regardless of Julia version.

test/runtests.jl Outdated Show resolved Hide resolved
Co-authored-by: Martin Holters <[email protected]>
@mcabbott
Copy link
Contributor Author

Yea maybe. I'd need another coffee to think about what happens on the Julia versions where this package stops exporting allequal but Base doesn't yet provide allequal(f, itr). If this package had never exported it, that would indeed be simpler.

@martinholters martinholters merged commit 82d1848 into JuliaLang:master Feb 19, 2024
20 checks passed
@mcabbott mcabbott deleted the allunique branch February 19, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants