-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allequal(f, itr)
and allunique(f, itr)
#818
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #818 +/- ##
==========================================
+ Coverage 92.37% 92.65% +0.28%
==========================================
Files 2 2
Lines 341 354 +13
==========================================
+ Hits 315 328 +13
Misses 26 26 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @test_skip
s are a bit unfortunate, but the documentation in Base allows this ("The precise number of calls is regarded as an implementation detail."), so ok.
But this reminds me of #814. We would be better off if we had defined unexported Compat.allequal
and Compat.allunique
. Then we could just keep rolling our own here, regardless of Julia version.
Co-authored-by: Martin Holters <[email protected]>
Yea maybe. I'd need another coffee to think about what happens on the Julia versions where this package stops exporting |
Adds JuliaLang/julia#47679