Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgversion #807

Merged
merged 8 commits into from
Jan 10, 2024
Merged

pkgversion #807

merged 8 commits into from
Jan 10, 2024

Conversation

palday
Copy link
Contributor

@palday palday commented Oct 5, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (0a507df) 92.99% compared to head (f39f862) 92.33%.

Files Patch % Lines
src/Compat.jl 84.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #807      +/-   ##
==========================================
- Coverage   92.99%   92.33%   -0.67%     
==========================================
  Files           2        2              
  Lines         314      339      +25     
==========================================
+ Hits          292      313      +21     
- Misses         22       26       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@martinholters martinholters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of docs/tests/version bump, this is all fine, but I have no idea whether the logic implemented here is ok. The tests pass, so it's probably good, but if anyone knowing about this stuff could take a brief look, that would be welcome.

src/Compat.jl Outdated Show resolved Hide resolved
src/Compat.jl Outdated Show resolved Hide resolved
src/Compat.jl Show resolved Hide resolved
src/Compat.jl Show resolved Hide resolved
src/Compat.jl Show resolved Hide resolved
src/Compat.jl Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@omus
Copy link
Member

omus commented Jan 10, 2024

Will merge after CI completes again

@omus
Copy link
Member

omus commented Jan 10, 2024

Not going to bother waiting on the Windows Julia 1.6 job as it passed on the previous commit and this last change was just documentation.

@omus omus merged commit 8e59d92 into JuliaLang:master Jan 10, 2024
19 of 20 checks passed
@palday palday deleted the pa/pkgversion branch January 10, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants