-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkgversion #807
pkgversion #807
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #807 +/- ##
==========================================
- Coverage 92.99% 92.33% -0.67%
==========================================
Files 2 2
Lines 314 339 +25
==========================================
+ Hits 292 313 +21
- Misses 22 26 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In terms of docs/tests/version bump, this is all fine, but I have no idea whether the logic implemented here is ok. The tests pass, so it's probably good, but if anyone knowing about this stuff could take a brief look, that would be welcome.
Co-authored-by: Martin Holters <[email protected]>
Co-authored-by: Curtis Vogt <[email protected]>
Will merge after CI completes again |
Not going to bother waiting on the Windows Julia 1.6 job as it passed on the previous commit and this last change was just documentation. |
No description provided.