Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add supports for new @inline and @noinline features #753

Merged
merged 1 commit into from
Sep 11, 2021
Merged

Conversation

@codecov
Copy link

codecov bot commented Sep 11, 2021

Codecov Report

Merging #753 (a572195) into master (d4e51c0) will decrease coverage by 0.92%.
The diff coverage is 56.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #753      +/-   ##
==========================================
- Coverage   79.06%   78.13%   -0.93%     
==========================================
  Files           4        4              
  Lines         597      622      +25     
==========================================
+ Hits          472      486      +14     
- Misses        125      136      +11     
Impacted Files Coverage Δ
src/Compat.jl 78.04% <56.00%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4e51c0...a572195. Read the comment docs.

@aviatesk aviatesk requested a review from timholy September 11, 2021 07:21
Base automatically changed from teh/constprop to master September 11, 2021 13:18
Copy link
Member

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see this until I'd already released, so this will have to go to 3.37 (sorry)

With a rebase, this looks GTG.

@aviatesk
Copy link
Member Author

No worries, I can also make a release :)

@aviatesk aviatesk merged commit cf3426b into master Sep 11, 2021
@aviatesk aviatesk deleted the avi/inline branch September 11, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants