Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add div(::Period, ::Period) method that's present in 1.8 #781

Closed
kleinschmidt opened this issue Sep 29, 2022 · 0 comments · Fixed by #782
Closed

add div(::Period, ::Period) method that's present in 1.8 #781

kleinschmidt opened this issue Sep 29, 2022 · 0 comments · Fixed by #782

Comments

@kleinschmidt
Copy link
Contributor

1.8.1 has a method for div on time periods which uses promote:

https://github.com/JuliaLang/julia/blob/b73bf8618579d5ae0327917af590d823a100ec82/stdlib/Dates/src/periods.jl#L101

1.7.3 doesn't have this though (looks like it was added this commit and included in 1.8.0). We could add these methods in compat behind a version guard to add support for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant