Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@test_logs needed for 0.6? #611

Closed
richardreeve opened this issue Aug 11, 2018 · 4 comments
Closed

@test_logs needed for 0.6? #611

richardreeve opened this issue Aug 11, 2018 · 4 comments

Comments

@richardreeve
Copy link

@test_warn is broken on 0.7 and 1.0 JuliaLang/julia#28549 and we should be using @test_logs instead, but that does not exist on 0.6... can this be provided in Compat, as apart from that my package is complete and testing well across 0.6-1.0!

@fredrikekre
Copy link
Member

fredrikekre commented Aug 11, 2018

Simce the internals have changed quite a bit I would just use an if around a version check and use @test_warn on 0.6 and @test_logs otherwise.

@richardreeve
Copy link
Author

Okay, I thought of doing that. The problem is that because @test_logs is a macro it fails on 0.6 even inside the if VERSION statement because it's not defined :(.

@fredrikekre
Copy link
Member

You can use @static if VERSION ....

@martinholters
Copy link
Member

Closing as outdated since we've dropped support for Julia prior to 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants