Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect deprecation for contains(str, regex) in Julia v0.7.0 #610

Closed
ltf-canada opened this issue Aug 10, 2018 · 2 comments
Closed

Incorrect deprecation for contains(str, regex) in Julia v0.7.0 #610

ltf-canada opened this issue Aug 10, 2018 · 2 comments

Comments

@ltf-canada
Copy link

contains(str, needle::String) has been deprecated. However from the release notes:

ismatch(regex, str) has been deprecated in favor of contains(str, regex)

It looks as if the deprecation is looking for something like an AbstractString and incorrectly catches the contains(str, regex) case.

@ltf-canada
Copy link
Author

It appears that this deprecation message is very misleading.

Function contains does not exist in Julia v1.0.0 at all. Instead the above deprecation message should state occursin(regex, str) instead.

@martinholters
Copy link
Member

Closing as outdated since we've dropped support for Julia prior to 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants