Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalization of numeric type constructors #32

Closed
sjkelly opened this issue Dec 21, 2014 · 6 comments
Closed

Capitalization of numeric type constructors #32

sjkelly opened this issue Dec 21, 2014 · 6 comments

Comments

@sjkelly
Copy link

sjkelly commented Dec 21, 2014

Running some libraries through Lint I see the following info:

INFO   In 0.4+, replace float64() with Float64()
INFO   In 0.4+, replace int64() with Int64()

Should these be aliased?

Related:
tonyhffong/Lint.jl#57

@ivarne
Copy link
Member

ivarne commented Dec 22, 2014

Base Julia has not yet decided what we want to do with the lowercase bitstype constructors.

They are there because there was a technical limitation that didn't allow having functions with the same name as bitstypes, but that restriction has been removed so usually you can just use the CamelCase version.

Currently Lint.jl just issues a notice because it seems likely that the lower case versions will be deprecated before 0.4 is officially released, and it is likely that those using 0.4-dev is interested in learning what is coming.

Sorry, Commented on this as if it was in the Lint.jl repository.

@ivarne
Copy link
Member

ivarne commented Dec 22, 2014

This can't be done because of technical limitations in 0.3. Julia has not yet decided what to do with the lowercase constructors, but it seems likely (to me) that we will deprecate them at some point.

We could add some code to the @compat macro though, so that Int, UInt, IntXX and UIntXX in a call context, gets rewritten to calls to the lowercase function.

@garborg
Copy link
Contributor

garborg commented Mar 16, 2015

With the deprecations that have come up recently on 0.4 for the lowercase versions those types and Bool, lots of IO code effectively hangs for me on 0.4 (even just running package tests -- small files).

For personal or new libraries, we're at the point where I've stopped supporting 0.3 because of the effort, but I'm talking about DataFrames, GZip, etc., here, so that's probably not an option quite yet. @ivarne's solution sounds reasonable, but anything would be great.

@garborg
Copy link
Contributor

garborg commented Mar 16, 2015

Ooops, looks like this was taken care of in #50. Sorry for the noise, and thanks, @jakebolewski!

@jakebolewski
Copy link
Member

The pause due to IO is a bug with the task switching code, not expected behavior. I think @andreasnoack was seeing this behavior as well.

@garborg
Copy link
Contributor

garborg commented Mar 17, 2015

Okay, that makes more sense. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants