Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to RR 5.7.0 - needed to support Intel Sapphire Rapids #140

Closed
BioTurboNick opened this issue Oct 5, 2023 · 4 comments
Closed

Update to RR 5.7.0 - needed to support Intel Sapphire Rapids #140

BioTurboNick opened this issue Oct 5, 2023 · 4 comments

Comments

@BioTurboNick
Copy link

BioTurboNick commented Oct 5, 2023

[FATAL src/PerfCounters_x86.h:118:compute_cpu_microarch()] Intel CPU type 0x806f0 unknown

Trying to trace a segfault in LLVM on 1.9.3 on a Sapphire Rapids CPU, but RR was failing because it didn't support the CPU.

Looks like just-released RR 5.7.0 includes this support:
https://github.com/rr-debugger/rr/blame/7cf5a12dba5aaeea9efc5ad97176b07b5614e350/src/PerfCounters_x86.h#L89-L90

@BioTurboNick BioTurboNick changed the title Update to RR 5.7.0 - needed to support Intel Sapphire Lake Update to RR 5.7.0 - needed to support Intel Sapphire Rapids Oct 5, 2023
@BioTurboNick
Copy link
Author

BioTurboNick commented Oct 7, 2023

cc: @maleadt, looks like you've been doing the most recent RR bumps on Yggdrasil? Is this an easy thing to do, or will it require some work? And if so, how can I help?

@maleadt
Copy link
Member

maleadt commented Oct 9, 2023

https://github.com/JuliaLang/rr/commits/release-5.6 would have to be rebased on top of master. The problem is that some of Keno's patches don't apply cleanly anymore on top of 5.7/master. I have the bare minimum in https://github.com/JuliaLang/rr/commits/tb/master (the XRC0 patch is so that we can replay traces from other processors), but there's also

Maybe @Keno can comment?

@BioTurboNick
Copy link
Author

I think all that may be needed to support Sapphire Rapids is just this small PR: rr-debugger/rr#3513

At least it seems to work on my machine.

@maleadt
Copy link
Member

maleadt commented Oct 24, 2023

OK, I can backport that. I'll wait for @Keno to chime in on the above patchlist before attempting an update to 5.7.

@maleadt maleadt closed this as completed Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants