-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to RR 5.7.0 - needed to support Intel Sapphire Rapids #140
Comments
cc: @maleadt, looks like you've been doing the most recent RR bumps on Yggdrasil? Is this an easy thing to do, or will it require some work? And if so, how can I help? |
https://github.com/JuliaLang/rr/commits/release-5.6 would have to be rebased on top of master. The problem is that some of Keno's patches don't apply cleanly anymore on top of 5.7/master. I have the bare minimum in https://github.com/JuliaLang/rr/commits/tb/master (the XRC0 patch is so that we can replay traces from other processors), but there's also
Maybe @Keno can comment? |
I think all that may be needed to support Sapphire Rapids is just this small PR: rr-debugger/rr#3513 At least it seems to work on my machine. |
OK, I can backport that. I'll wait for @Keno to chime in on the above patchlist before attempting an update to 5.7. |
Trying to trace a segfault in LLVM on 1.9.3 on a Sapphire Rapids CPU, but RR was failing because it didn't support the CPU.
Looks like just-released RR 5.7.0 includes this support:
https://github.com/rr-debugger/rr/blame/7cf5a12dba5aaeea9efc5ad97176b07b5614e350/src/PerfCounters_x86.h#L89-L90
The text was updated successfully, but these errors were encountered: