Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add char types to enum alias link #520

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

christiangnrd
Copy link
Contributor

Feel free to close if I'm incorrect, but I think the "primitive enum values" should be the same in the LinkEnumAlias pass as the ones from cursor.jl?

Clang.jl/src/cursor.jl

Lines 245 to 255 in 572eddf

if typeKind == CXType_Int ||
typeKind == CXType_Long ||
typeKind == CXType_LongLong ||
typeKind == CXType_Char_S # enum : char
return clang_getEnumConstantDeclValue(c)
elseif typeKind == CXType_UInt ||
typeKind == CXType_ULong ||
typeKind == CXType_ULongLong ||
typeKind == CXType_UChar
return clang_getEnumConstantDeclUnsignedValue(c)
end

@Gnimuc
Copy link
Member

Gnimuc commented Dec 12, 2024

LGTM

@Gnimuc Gnimuc merged commit 7bd4dc0 into JuliaInterop:master Dec 12, 2024
6 of 11 checks passed
@christiangnrd christiangnrd deleted the moreenum branch December 12, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants