-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widen integer literal to unsigned when required #516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to make a changelog entry too :)
Nightly failures seem unrelated, locally the fix handles hexadecimal and decimal literal integers correctly (using |
Sorry forgot to mention, could we add a test too? I would recommend adding a header file in https://github.com/JuliaInterop/Clang.jl/tree/master/test/include and then using it in https://github.com/JuliaInterop/Clang.jl/blob/master/test/generators.jl. |
Sure, thanks for the pointer! |
7f73ecd
to
6ed0e00
Compare
All good :) |
Unofficial LGTM! |
Thanks! |
Fixes #515.
This include an additional fix with
txt_no_sfx = replace(txt_no_sfx, r"^0X" => "0x")
to also support integer constants formatted as0X012345678
, which otherwise throw an error when executed.