Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discourage convert(Array{C}, img) in favor of broadcasting #153

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

timholy
Copy link
Member

@timholy timholy commented Aug 26, 2020

@timholy
Copy link
Member Author

timholy commented Aug 26, 2020

Several of these were not problematic in their original form, but my thought is that we should discourage anything that might encourage users to use convert(Array{C}, img).

Do you think we need to have a docs warning that convert(Array{RGB}, img) will result in an abstract eltype but that RGB.(img) will be concrete?

@johnnychen94
Copy link
Member

johnnychen94 commented Aug 26, 2020

Do you think we need to have a docs warning that convert(Array{RGB}, img) will result in an abstract eltype but that RGB.(img) will be concrete?

We can add it in #146. @mgautam98 do you want to continue that PR recently?

@mgautam98
Copy link
Collaborator

I can add it in #146. @mgautam98 do you want to continue that PR recently?

Yes, I want to continue. I will add this warning.

@timholy timholy merged commit 3a4e439 into source Aug 31, 2020
@timholy timholy deleted the teh/convert_deprecation branch August 31, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants