Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switching registration system #798

Closed
johnnychen94 opened this issue Apr 16, 2019 · 7 comments
Closed

switching registration system #798

johnnychen94 opened this issue Apr 16, 2019 · 7 comments

Comments

@johnnychen94
Copy link
Member

johnnychen94 commented Apr 16, 2019

I tried to upgrade ImageMorphology to support Julia v1.0 and v1.1 in JuliaImages/ImageMorphology.jl#14 and fix broken CI, also a release v0.2.0 is published.

But in Julia CLI it says no such release

(v1.0) pkg> activate .

(jc) pkg> add ImageMorphology@0.2
  Updating registry at `~/.julia/registries/General`
  Updating git-repo `https://github.com/JuliaRegistries/General.git`
 Resolving package versions...
ERROR: Unsatisfiable requirements detected for package ImageMorphology [787d08f9]:
 ImageMorphology [787d08f9] log:
 ├─possible versions are: [0.0.1-0.0.2, 0.1.0-0.1.1] or uninstalled
 └─restricted to versions 0.2 by an explicit requirement — no versions left

Looks like it's because attobot is disabled according to switching package registration system, and we need a change from attobot to Registrator

And looks like installing new Registrator will be enough to fix this release failure, but this's out of my knowledge at present :(

cc: @timholy

@johnnychen94
Copy link
Member Author

johnnychen94 commented Apr 17, 2019

Looks like this was caused by incorrect release name. It should be v0.2.0 and I named it 0.2.0

@timholy
Copy link
Member

timholy commented Apr 17, 2019

@RalphAS installed the new Registrator, so you should be able to do it now.

@johnnychen94
Copy link
Member Author

johnnychen94 commented Apr 21, 2019

Looks like the new Registrator isn't compatible with the old one. Once the upstream dependency tagged a new release, there would be version conflict in the downstream unless explicitly specifying a old version.

For example, I've released an ImageMorphology v0.2.0 using the new Registrator, (the same to ColorVectorSpace)

(v1.1) pkg> activate .

(tmp) pkg> add ImageMorphology
  Updating registry at `~/.julia/registries/General`
  Updating git-repo `https://github.com/JuliaRegistries/General.git`
 Resolving package versions...
  Updating `~/tmp/Project.toml`
  [787d08f9] + ImageMorphology v0.2.0
  Updating `~/tmp/Manifest.toml`
  ...

(tmp) pkg> add ImageInpainting
 Resolving package versions...
ERROR: Unsatisfiable requirements detected for package ImageMorphology [787d08f9]:
 ImageMorphology [787d08f9] log:
 ├─possible versions are: [0.0.1-0.0.2, 0.1.0-0.1.1, 0.2.0] or uninstalled
 ├─restricted to versions 0.2.0 by an explicit requirement, leaving only versions 0.2.0
 └─restricted by compatibility requirements with ImageInpainting [2bcd8d84] to versions: [0.0.2, 0.1.0-0.1.1] — no versions left
   └─ImageInpainting [2bcd8d84] log:
     ├─possible versions are: [0.0.1-0.0.2, 0.1.0] or uninstalled
     └─restricted to versions * by an explicit requirement, leaving only versions [0.0.1-0.0.2, 0.1.0]

repos that lack of Project.toml and need updates: (sorted by update time: from latest to oldest)

Are following repos deprecated, or are they just need someone to maintain? (they're not updated for at least two years)

I can help to fill these Project.toml and fix travis.yml. In the meantime, I'm not sure if we should drop julia v0.7 support, more specifically, should I

  • set julia v0.7 compatible in Project.toml
  • drop julia v0.7 test in travis.yml

a small talk with @Evizero says once 1.0 works we can drop 0.7. I guess we only need at most three versions under CI test, i.e., 1.0 as LTS version, 1.1 as the latest release version, and nightly build which allows failure.

@johnnychen94
Copy link
Member Author

I'm not sure if we should drop julia v0.7 support, more specifically, should I

  • set julia v0.7 compatible in Project.toml
  • drop julia v0.7 test in travis.yml

JuliaImages/ImageCore.jl#71 (comment)

Conclusion: set v0.7 incompatible when we drop the CI test for it.

I guess we only need at most three versions under CI test, i.e., 1.0 as LTS version, 1.1 as the latest release version, and nightly build which allows failure.

JuliaImages/ImageView.jl#171 (comment)

The answer is yes.

@johnnychen94
Copy link
Member Author

johnnychen94 commented Apr 23, 2019

There's a registrator bug for julia version compatibility julia = ">= 1.0" as described https://github.com/JuliaComputing/Registrator.jl/issues/103

The following package versions aren't compatible for julia version >=1.3:

  • Images v0.18.0
  • ImageMorphology v0.2.0
  • ImageMetadata v0.7.0
  • TestImages v0.5.0

(Possibly would be fixed in General in the future)

@johnnychen94
Copy link
Member Author

A large part of the switching procedure is finished except ImageTracking and ImageInpainting, which are not registered yet.

@timholy
Copy link
Member

timholy commented Apr 30, 2019

Thanks so much @johnnychen94 for your steadfast stewardship of this transition! 🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants