Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't complement live in Colors.jl? #698

Closed
yakir12 opened this issue Jan 23, 2018 · 5 comments
Closed

Shouldn't complement live in Colors.jl? #698

yakir12 opened this issue Jan 23, 2018 · 5 comments

Comments

@yakir12
Copy link
Contributor

yakir12 commented Jan 23, 2018

Small function, small issue, but seems like complement which acts on a color should live in Colors.jl.

@SimonDanisch
Copy link
Member

I think there are a few functions, that should actually live in Colors.jl instead of Images.jl.
E.g. clamp01, reexport of N0f8 - probably more! How about we make a list, confirm that they should move and then make a PR?

@bjarthur
Copy link
Collaborator

mapwindow also strikes me as misplaced, as i often use it for time series. seems equally suited to me to be in a signal processing package.

@yakir12
Copy link
Contributor Author

yakir12 commented Jan 24, 2018

I agree with all of that.

Since there are currently 448 packages that depend on Colors, there might be some resistance to adding any functions to it (thus making it ever so slightly larger).

I tried to find the methods that use Color in Images by looking at the output from methodswith(Color) after using Images, but didn't get any useful result. Can you compile a list of Images functions that act upon types of Colors?

As to mapwindow, yea I find myself using Images just for some of the filter functions there, even when I only need it for a Vector...

@kimikage
Copy link

kimikage commented Jan 6, 2020

BTW, if you move complement to another package, I think ColorVectorSpace.jl is more appropriate package than Colors.jl.

@wizofe
Copy link

wizofe commented Mar 7, 2020

I attempted a PR for both steps! Being a GSoC student; be kind ^_^

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants