Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retrieve! for VideoReader{NO_TRANSCODE} does nothing #111

Closed
tibaes opened this issue Dec 1, 2017 · 1 comment · Fixed by #277
Closed

retrieve! for VideoReader{NO_TRANSCODE} does nothing #111

tibaes opened this issue Dec 1, 2017 · 1 comment · Fixed by #277

Comments

@tibaes
Copy link

tibaes commented Dec 1, 2017

I am trying to get a NO_TRANCODE image, however read / retrieve returns a Void.
Reading the code I found weird that retrieve! does not return the buf.

function retrieve!{T<:EightBitTypes}(r::VideoReader{NO_TRANSCODE}, buf::VidArray{T})
    while !have_frame(r)
        idx = pump(r.avin)
        idx == r.stream_index0 && break
        idx == -1 && throw(EOFError())
    end

    if !bufsize_check(r, buf)
        error("Buffer is the wrong size")
    end
end

I believe that this function does nothing on practice, as there is no copy of the image buffer to buf; neither this buffer is returned.

@kmsquire
Copy link
Collaborator

Still an issue--this was never completely implemented, it seems. Mea culpa!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants