Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_logger not defined #55

Closed
laggvar opened this issue Jun 22, 2023 · 2 comments · Fixed by #56
Closed

_logger not defined #55

laggvar opened this issue Jun 22, 2023 · 2 comments · Fixed by #56

Comments

@laggvar
Copy link

laggvar commented Jun 22, 2023

PortAudio.jl fails during precompilation when using the latest version of Suppessor.jl.

The reason seems to be it calls @capture_err within __init__(), causing

ERROR: LoadError: InitError: UndefVarError: `_logger` not defined

Indeed, _logger is not assigned in all branches of the if-statements just above the line

Suppressor.jl/src/Suppressor.jl

Line 39 in 2002595

Logging.with_logger(_logger) do

@aviks
Copy link

aviks commented Jun 25, 2023

I'm seeing this as well. I can confirm fixing Supressor to v0.2.0 make the problem go away.

The problematic line seems to be last touched in #53

cc: @Drvi @quinnj

@Drvi
Copy link
Member

Drvi commented Jun 25, 2023

Ah, I see the problem, will look into it

@Drvi Drvi mentioned this issue Jun 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Define _logger during precompilation Drvi/Suppressor.jl
3 participants
@aviks @Drvi @laggvar