Fixes for julia 0.7 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed some of the Char and Expr issues in JuliaIO/JLD.jl#229. |
|
These tests and JLD depend on each other, so I'll just merge this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is coordinated with JuliaIO/JLD.jl#215.
I've had to disable a few tests here as well, mostly for the same reasons as detailed in the JLD PR (alignment issues with mmap, a problem with a struct containing a union of bitskind types).
Additionally, there are two new issues:
Exprhas changed in 0.7, the fieldtypwas removedCharwas also changed, so that the bits stored in old archives are now interpreted differently.All disabled tests are marked with FIXME comments.
Any pointers on how to fix the above mentioned issues would be appreciated. Alternatively, this PR might be merged and the issues fixed by someone more knowledgeable than me.