Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reason for Documenter being a dependency #19

Closed
theogf opened this issue Oct 4, 2023 · 6 comments · Fixed by #20
Closed

Reason for Documenter being a dependency #19

theogf opened this issue Oct 4, 2023 · 6 comments · Fixed by #20

Comments

@theogf
Copy link

theogf commented Oct 4, 2023

It looks like Documenter is a dependency of GoogleDrive but is not actually used? Could it be removed?

@JeffFessler
Copy link
Member

Hopefully fixed by #20
Since you submitted this issue, presumably you are actually trying to use the package.
Could you test your use case on the master branch and then let me know if it works for you?
If it does, I'll tag the current release despite the Docs not building properly...

@theogf
Copy link
Author

theogf commented Oct 4, 2023

Yeah, it is more of a dependency issue actually, I do not directly depend on GoogleDrive but Embeddings.jl does. I could have a look if the breaking changes create an issue

@theogf
Copy link
Author

theogf commented Oct 4, 2023

Actually looking at the code, I could not find anything breaking that would lead to 0.2 ?

@JeffFessler
Copy link
Member

Ah good point, we just added functions, so I guess 0.1.2 is the appropriate bump. I'll fix that.

@JeffFessler
Copy link
Member

ok, working on tagging the release but there is a hiccup due to the repo relocation:
71829fd

@theogf
Copy link
Author

theogf commented Oct 4, 2023

Once JuliaRegistries/General#92753 is merged, one should be able to make a release with 0.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants