Detect truncated frames to avoid infinite loop #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #47 +/- ##
==========================================
+ Coverage 30.98% 31.84% +0.86%
==========================================
Files 5 5
Lines 510 515 +5
==========================================
+ Hits 158 164 +6
+ Misses 352 351 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24
The streaming decompression function will only return zero when a frame is fully decoded and flushed out.
If the return value is not an error it will be less than or equal to the number of bytes left in the frame that haven't been read yet.
If
processis called withinput.size==0there is no more data left to decompress.So if there is no more data left to decompress, but zstd is asking for more data, then the frame is truncated, and error should be returned.
Ref: facebook/zstd#340 (comment) facebook/zstd#1109 https://github.com/facebook/zstd/blob/dev/examples/streaming_decompression.c