Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slower than expected decompression, round 2 #19

Closed
jrevels opened this issue Jan 31, 2020 · 2 comments · Fixed by #20
Closed

slower than expected decompression, round 2 #19

jrevels opened this issue Jan 31, 2020 · 2 comments · Fixed by #20

Comments

@jrevels
Copy link

jrevels commented Jan 31, 2020

Spiritual successor to #13; not sure what the culprit is this time:

julia> using CodecZstd, TranscodingStreams

julia> bytes = read("fid_1509_2018_LTM.edf.zst");

julia> @time transcode(ZstdDecompressor, bytes);
 27.252612 seconds (594.62 k allocations: 1.858 GiB, 0.02% gc time)
>>> import zstandard as zstd
>>> import timeit
>>> byts = open('fid_1509_2018_LTM.edf.zst', 'rb').read();
>>> d = zstd.ZstdDecompressor()
>>> timeit.timeit("d.decompress(byts)", number=1, globals=globals())
3.793142723850906
@jrevels
Copy link
Author

jrevels commented Jan 31, 2020

This might be the same issue as #17?

@jrevels
Copy link
Author

jrevels commented Jan 31, 2020

Yup, it's the same regression as #17. After downgrading to v0.6.0:

julia> @time transcode(ZstdDecompressor, bytes);
  3.765080 seconds (594.58 k allocations: 1.858 GiB, 0.15% gc time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant