Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are all 3 compressors in this package literally identical? #44

Closed
oxinabox opened this issue May 24, 2019 · 1 comment
Closed

Are all 3 compressors in this package literally identical? #44

oxinabox opened this issue May 24, 2019 · 1 comment

Comments

@oxinabox
Copy link

The names seem synomous to me,
and the code for each looks identical.
Am I missing something?

@bicycle1885
Copy link
Member

Each compressor has a different range of thewindowbits parameter that is passed to zlib. Adding a magic number to the parameter or flipping the sign of it creates a different kind of compressor, but I think it is much clearer to allocate different names (types) to different compressors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants