improve CI-time 100x by commenting out the top-level testset #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
changed the title
kescobo
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
😬 That's not awesome, though nice that the fix is so easy.
I think this is great, only question is whether there are any changes to the inner testset names that would improve clarity now that they're not nested, like "Output stream: arrays" instead of "arrays"?
|
Seeing this package time out on PkgEval reminded me of this PR. I added the suggestion change to the inner test set names. |
|
Sorry I didn't merge before - i wrote my comment and then forgot about it 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the test take seconds on my machine compared to ~15 min that it seems to take on CI