Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better negative sampling + remove_multi_edges + is_bidirected + DotDecoder #69

Merged
merged 6 commits into from
Nov 3, 2021

Conversation

CarloLucibello
Copy link
Member

@CarloLucibello CarloLucibello commented Nov 2, 2021

TODO

  • add bidirectional sampling option
  • add tests for negative_sample

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #69 (e4b7557) into master (e5e919c) will decrease coverage by 0.62%.
The diff coverage is 38.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   80.10%   79.47%   -0.63%     
==========================================
  Files          12       12              
  Lines         794      838      +44     
==========================================
+ Hits          636      666      +30     
- Misses        158      172      +14     
Impacted Files Coverage Δ
src/GNNGraphs/generate.jl 100.00% <ø> (ø)
src/GNNGraphs/gnngraph.jl 67.24% <0.00%> (-4.99%) ⬇️
src/layers/basic.jl 48.78% <ø> (-3.86%) ⬇️
src/GNNGraphs/transform.jl 81.69% <43.58%> (-1.04%) ⬇️
src/GNNGraphs/query.jl 86.84% <100.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e919c...e4b7557. Read the comment docs.

@CarloLucibello CarloLucibello changed the title better negative sampling better negative sampling + remove_multi_edges + is_bidirected + DotDecoder Nov 2, 2021
@CarloLucibello CarloLucibello merged commit 683c8b7 into master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant