New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated method definitions of GINConv #406

Closed

bicycle1885 opened this issue Mar 6, 2024 · 1 comment

Contributor

bicycle1885 commented Mar 6, 2024

I see the following warning while precompiling the package:

WARNING: Method definition (::GraphNeuralNetworks.GINConv{R<:Real, NN, A})(GraphNeuralNetworks.GNNGraphs.TemporalSnapshotsGNNGraph, AbstractArray{T, 1} where T) in module GraphNeu
ralNetworks at /home/kenta/.julia/packages/GraphNeuralNetworks/a5Jzz/src/layers/temporalconv.jl:190 overwritten at /home/kenta/.julia/packages/GraphNeuralNetworks/a5Jzz/src/layers
/temporalconv.jl:210.

As the message says, we can find duplicated method definitions for GINConv:
https://github.com/CarloLucibello/GraphNeuralNetworks.jl/blob/76711ba361e9065371e256ab5513099a163c5ef3/src/layers/temporalconv.jl#L190
https://github.com/CarloLucibello/GraphNeuralNetworks.jl/blob/76711ba361e9065371e256ab5513099a163c5ef3/src/layers/temporalconv.jl#L210

The text was updated successfully, but these errors were encountered:

Member

aurorarossi commented Mar 6, 2024

Line 190 was added in 0780fe8 then duplicated in 50ebac3
I will fix this, thanks for pointing this out !

aurorarossi mentioned this issue

Remove duplicate of GINConv for TemporalSnapshotsGNNGraph #409

Merged

CarloLucibello closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment