Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Example Code #346

Closed
eahenle opened this issue Sep 27, 2023 · 0 comments · Fixed by #347
Closed

Error in Example Code #346

eahenle opened this issue Sep 27, 2023 · 0 comments · Fixed by #347

Comments

@eahenle
Copy link
Contributor

eahenle commented Sep 27, 2023

The example code at https://carlolucibello.github.io/GraphNeuralNetworks.jl/stable/ has a small problem:

[...]
for epoch in 1:100
    [...]
    @info (; epoch, train_loss=loss(train_loader), test_loss=loss(test_loader))
end

There is no function signature for loss(dl::DataLoader). The fix is obviously simple: add the required model arg--PR inbound 😉

I could also make a PR to implement CI testing on the docs examples, if that would be welcome. I like doing that for my packages, since this kind of thing has a way of popping up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant