Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_edges adds a non-existent edge to its DataStore #280

Closed
bicycle1885 opened this issue May 5, 2023 · 2 comments · Fixed by #286
Closed

add_edges adds a non-existent edge to its DataStore #280

bicycle1885 opened this issue May 5, 2023 · 2 comments · Fixed by #286

Comments

@bicycle1885
Copy link
Contributor

julia> using GraphNeuralNetworks

julia> g = GNNGraph([1], [2])
GNNGraph:
  num_nodes: 2
  num_edges: 1

julia> h = add_edges(g, Int[], Int[])  # adds no edges
GNNGraph:
  num_nodes: 2
  num_edges: 1

julia> g.edata._n  # this is one, of course
1

julia> h.edata._n  # but this is two, which is unexpected
2

I tested this on Julia 1.8.5 and the latest master branch of GraphNeuralNetworks.jl.

@bicycle1885
Copy link
Contributor Author

@CarloLucibello
Copy link
Member

I don't remember the reason for those cheks, I'll investigate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants