Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCNConv without normalization #277

Closed
FDemelas opened this issue Apr 27, 2023 · 3 comments
Closed

GCNConv without normalization #277

FDemelas opened this issue Apr 27, 2023 · 3 comments

Comments

@FDemelas
Copy link

Hello, I'm trying to use GCNConv with negative edge weights, hence I would like to deactivate the normalization as clearly the square root of negative value is problematic.
Is it possible in some way to deactivate the normalization (but still use the edge weights) or change with a personalized normalization?

@CarloLucibello
Copy link
Member

Hi, we don't support that currently. It would be nice to add the possibility of a custom normalization (PR welcome!).
As a quick workaround you can define your own custom layer by copying and pasting the GCNConv implementation and
removing the normalization
https://github.com/CarloLucibello/GraphNeuralNetworks.jl/blob/a7de26fc65e46f6f29208b8d365b9c0e79a1390a/src/layers/conv.jl#L125-L126

@FDemelas
Copy link
Author

Thank you very much

@rbSparky
Copy link
Contributor

rbSparky commented Jan 1, 2024

Seems like a quick fix

@CarloLucibello should I create a PR that adds the possibility of custom normalization in GCNConv?

Edit: Made the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants