Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for additonal features in GNNGraph #210

Closed
Dsantra92 opened this issue Oct 1, 2022 · 5 comments
Closed

Allow for additonal features in GNNGraph #210

Dsantra92 opened this issue Oct 1, 2022 · 5 comments

Comments

@Dsantra92
Copy link
Collaborator

There are cases where the shape of the feature array might not have the last dim = number of nodes and edges.
For example: In a mesh represented by a graph where the vertices are nodes. Currently, there is no way to include triangular faces, except for graph data (which they are not).

GNNGraph should be allowed to contain such features which are not either node or edge.
cc: @CarloLucibello

@CarloLucibello
Copy link
Member

How does PyG works in this setting?

@Dsantra92
Copy link
Collaborator Author

PyG doesn't force checks on features.

@CarloLucibello
Copy link
Member

Why we can't store them as graph data?

@Dsantra92
Copy link
Collaborator Author

We can do it given our current implementation. But at the end of the day, they are not exactly graph level features.

@CarloLucibello
Copy link
Member

closing as it not clear how to act on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants