Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect webcomponents URL on JuliaBox in iframe #98

Closed
rdeits opened this issue May 2, 2018 · 2 comments · Fixed by #99
Closed

Incorrect webcomponents URL on JuliaBox in iframe #98

rdeits opened this issue May 2, 2018 · 2 comments · Fixed by #99

Comments

@rdeits
Copy link
Collaborator

rdeits commented May 2, 2018

On JuliaBox, WebIO tries to load the webcomponents module from:

https://juliabox.com/pkg/WebIO/webio/dist/webcomponents-lite.min.js

but instead, it needs to be:

https://juliabox.com/notebook/pkg/WebIO/webio/dist/webcomponents-lite.min.js

It's probably just another absolute vs. relative path thing. I'll see if I can fix it.

@rdeits
Copy link
Collaborator Author

rdeits commented May 2, 2018

Ah, I see. This only happens inside an iframe when trying to load webio.

@rdeits
Copy link
Collaborator Author

rdeits commented May 2, 2018

At least two things need to be done to fix this:

  • change the webio js path from /pkg/.../bundle.js to pkg/.../bundle.js in iframe.jl
  • do the same <base href trick that ijulia_setup.jl does inside the iframe

@rdeits rdeits changed the title Incorrect webcomponents URL on JuliaBox Incorrect webcomponents URL on JuliaBox in iframe May 3, 2018
@shashi shashi closed this as completed in #99 May 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant