Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GeoInterace methods to an extension in GeoInterface to remove dependency loops #221

Open
rafaqz opened this issue Oct 12, 2024 · 3 comments

Comments

@rafaqz
Copy link
Contributor

rafaqz commented Oct 12, 2024

As MakieCore depends on GeometryBasics there is no way for GeoInterface to add makie recipes without a dependency loop.

We want the GeoInterface geometries to plot easily, and for our macro to add Makie recipes to be useable from GeoInterface.

The problem is going to be managing the transition without breaking lots of code and / or precompile.

See JuliaGeo/GeoInterface.jl#143

@asinghvi17
Copy link
Contributor

Can you call geointerface_geomtype methods from an extension? Those at least need GI traits for dispatch...

@rafaqz
Copy link
Contributor Author

rafaqz commented Oct 12, 2024

Good point. We can shift to module dispatch in GI.convert so geointerface_geomtype isn't hit.

That's the plan anyway with 1.10 being LTS

@asinghvi17
Copy link
Contributor

Ah, yeah the current method could be kept as a fallback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants