Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test new drivers for new GDAL_jll release. #99

Merged
merged 3 commits into from
Nov 21, 2020
Merged

Conversation

evetion
Copy link
Member

@evetion evetion commented Oct 20, 2020

Still needs a release of JuliaPackaging/Yggdrasil#1941.

Because no version has been upped of GDAL_jll, not sure how to actually point to it apart from a git hash. v3.0.4+2 is not a valid version number.

@evetion evetion requested a review from visr October 20, 2020 12:11
@visr
Copy link
Member

visr commented Oct 20, 2020

Thanks! Indeed there is nothing that Pkg can do to select build numbers. It will always pick the latest one available, so this is fine as is.

@evetion
Copy link
Member Author

evetion commented Oct 20, 2020

Btw, it fails now on the LVBAG driver, while it should already work, libexpat is in there now. I'm happy to also drop that driver from this PR.

@visr
Copy link
Member

visr commented Oct 20, 2020

I see the page says the LVBAG driver is new in GDAL 3.2, which will be released in 2 weeks :)

@evetion
Copy link
Member Author

evetion commented Oct 20, 2020

Well that does explain things. 🤔 I'll update and then it's ready to merge.

@evetion evetion marked this pull request as ready for review October 20, 2020 17:35
visr added a commit to visr/General that referenced this pull request Oct 20, 2020
It fails GDAL.jl CI in JuliaGeo/GDAL.jl#99 with `Incompatible library version: libgdal.26.dylib requires version 12.0.0 or later, but libxml2.2.dylib provides version 10.0.0` It seems to be picking up a libxml2 that was not intended.
giordano pushed a commit to JuliaRegistries/General that referenced this pull request Oct 20, 2020
It fails GDAL.jl CI in JuliaGeo/GDAL.jl#99 with `Incompatible library version: libgdal.26.dylib requires version 12.0.0 or later, but libxml2.2.dylib provides version 10.0.0` It seems to be picking up a libxml2 that was not intended.
@visr
Copy link
Member

visr commented Oct 20, 2020

The build was unfortunately broken, so we had to yank it: JuliaRegistries/General#23343.

The OSX failure says: Incompatible library version: libgdal.26.dylib requires version 12.0.0 or later, but libxml2.2.dylib provides version 10.0.0. @giordano mentioned that JuliaHub shows XML2_jll is an indirect dependency. But also that the version in Yggdrasil should be version 12, so it is actually picking up a wrong version. He also said that "if someone has macOS, looking at Libdl.dllist() would help a lot".

@visr
Copy link
Member

visr commented Oct 20, 2020

Also quoting Mosè from Slack:

sandbox:${WORKSPACE} # otool -L libgdal.dylib 
libgdal.dylib:
        @rpath/libgdal.26.dylib (compatibility version 27.0.0, current version 27.4.0)
        @rpath/libgeos_c.1.dylib (compatibility version 15.0.0, current version 15.3.0)
        @rpath/libwebp.7.dylib (compatibility version 9.0.0, current version 9.0.0)
        @rpath/libsqlite3.0.dylib (compatibility version 9.0.0, current version 9.6.0)
        @rpath/libexpat.1.dylib (compatibility version 8.0.0, current version 8.9.0)
        @rpath/libopenjp2.7.dylib (compatibility version 7.0.0, current version 2.3.1)
        @rpath/libgif.7.dylib (compatibility version 8.0.0, current version 8.0.0)
        @rpath/libjpeg.62.dylib (compatibility version 62.0.0, current version 62.3.0)
        @rpath/libtiff.5.dylib (compatibility version 11.0.0, current version 11.0.0)
        @rpath/libpng16.16.dylib (compatibility version 16.0.0, current version 16.37.0)
        @rpath/libzstd.1.dylib (compatibility version 1.0.0, current version 1.0.0)
        @rpath/libproj.19.dylib (compatibility version 19.0.0, current version 19.1.0)
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1238.0.0)
        @rpath/libcurl.4.dylib (compatibility version 11.0.0, current version 11.0.0)
        @rpath/libnghttp2.14.dylib (compatibility version 34.0.0, current version 34.0.0)
        @rpath/libssh2.1.dylib (compatibility version 1.0.0, current version 1.0.1)
        @rpath/libmbedtls.12.dylib (compatibility version 12.0.0, current version 2.16.8)
        @rpath/libmbedx509.0.dylib (compatibility version 0.0.0, current version 2.16.8)
        @rpath/libmbedcrypto.3.dylib (compatibility version 3.0.0, current version 2.16.8)
        @rpath/libxml2.2.dylib (compatibility version 12.0.0, current version 12.10.0)
        @rpath/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
        @rpath/libiconv.2.dylib (compatibility version 9.0.0, current version 9.1.0)
        /usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 307.4.0)

it's already pointing to "the right one"

but it looks like another libxml2 is being loaded before julia has the time to load the right one

visr added a commit to visr/Yggdrasil that referenced this pull request Nov 19, 2020
`webp` is removed since it brings in `libxml2` which broke the GDAL build, see JuliaGeo/GDAL.jl#99

PROJ_jll is fixed to 7.2 since the minor version is part of the DLL filename, causing
JuliaGeo/GDAL.jl#102
giordano pushed a commit to JuliaPackaging/Yggdrasil that referenced this pull request Nov 19, 2020
`webp` is removed since it brings in `libxml2` which broke the GDAL build, see JuliaGeo/GDAL.jl#99

PROJ_jll is fixed to 7.2 since the minor version is part of the DLL filename, causing
JuliaGeo/GDAL.jl#102
No need to tag this, since users will get the new build automatically.
@visr visr merged commit 4a7a917 into master Nov 21, 2020
@visr visr deleted the update-new-drivers branch November 21, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants