Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no need to set the certificates on 1.6+ #117

Merged
merged 2 commits into from
May 28, 2021
Merged

no need to set the certificates on 1.6+ #117

merged 2 commits into from
May 28, 2021

Conversation

visr
Copy link
Member

@visr visr commented May 26, 2021

@visr
Copy link
Member Author

visr commented May 26, 2021

This doesn't work on Linux for julia 1.6+, throwing a "CURL error: Cert verify failed: BADCERT_NOT_TRUSTED"

I also found this comment: JuliaLang/julia#39289 (comment).

Though it is probably preferable to just use https://github.com/JuliaLang/NetworkOptions.jl, and remove the MozillaCACerts_jll dependency, for all julia versions. NetworkOptions also installs on older julia versions. Quickly reading the README, it seems we could call ca_roots, and set it with cplsetconfigoption if the result is not nothing.

EDIT: NetworkOptions works, with the addition that on older julia versions we should use ca_roots_path instead, such that the bundled certificates are used on Windows and macOS, because otherwise it doesn't work.

@visr visr merged commit c740522 into master May 28, 2021
@visr visr deleted the cert16 branch May 28, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error setting certificate verify locations
1 participant