Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataDeps warning when running get #65

Closed
asinghvi17 opened this issue Apr 17, 2024 · 1 comment · Fixed by #69
Closed

DataDeps warning when running get #65

asinghvi17 opened this issue Apr 17, 2024 · 1 comment · Fixed by #69
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@asinghvi17
Copy link
Member

GADM.get("JPN") # first run

yields a warning:

┌ Warning: Checksum not provided, add to the Datadep Registration the following hash line
│   hash = "a7d0955dfd9215d6b21cff3f5b7bf09b02c3b64290e7b6ac1b357b7789f45e03"
└ @ DataDeps ~/.julia/packages/DataDeps/Y2lje/src/verification.jl:44

I get similar errors for every other country. This should probably be resolved in the registration block here:

GADM.jl/src/GADM.jl

Lines 64 to 69 in 606b61a

register(DataDep(ID,
"Geographic data for country $country provided by the https://gadm.org project.",
"$route/$filename",
post_fetch_method=postfetch
))
@datadep_str ID

@juliohm juliohm added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Apr 17, 2024
@juliohm
Copy link
Member

juliohm commented Apr 17, 2024

If the hash is fixed per ID, then a dictionary can be introduced in the code for lookup. PRs are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants