Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Base.keys(ds) to varnames(ds) #26

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

lupemba
Copy link

@lupemba lupemba commented Oct 9, 2024

  • Add Base.keys(ds) = varnames(ds) keys have a default method.
  • Define varnames instead of Base.keys for Datasets to align better with the interface description.
  • Add small tests
    See issue for more context. Should Base.keys(ds) default to varnames(ds) #25

@lupemba
Copy link
Author

lupemba commented Oct 9, 2024

There is errors in the integration tests.

  • The TIFFDatasets.jl fail looks like an issue with GDAL and not something related to the PR.
  • The GRIBDataset.jl fail might be related to the PR. I have tried to run the GRIBDataset.jl test locally from main using the PR as a dev dependency. The two test with errors in CI passes on my machine. Instead some other tests fails because I run windows.

@Alexander-Barth
Copy link
Member

Thanks a lot, Simon!
Yes, the failures are indeed independent.

See also:
JuliaGeo/GRIBDatasets.jl#35
JuliaGeo/GDAL.jl#179

@Alexander-Barth Alexander-Barth merged commit 1a1a3e3 into JuliaGeo:main Oct 9, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants