Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the AbstractGPs internal API #35

Open
rossviljoen opened this issue Feb 26, 2022 · 3 comments
Open

Implement the AbstractGPs internal API #35

rossviljoen opened this issue Feb 26, 2022 · 3 comments

Comments

@rossviljoen
Copy link
Contributor

Would it make sense to implement the internal API for cov & var and remove the definitions for FiniteBLR?

It would add some currently missing methods like cov(f, x, y)

@willtebbutt
Copy link
Member

Hmmmm. Do you have a particular use case for cov(f, x, y) with a BLR? I don't have any super strong objections, I'm more just intriuged as to where it's useful.

@rossviljoen
Copy link
Contributor Author

I think I came across it when writing tests, so I don't have a practical use case in mind.

The major benefit would be that BLRs could be more easily substituted in downstream things that require a GP and might want cov(f, x, y) for some reason.

@willtebbutt
Copy link
Member

Hmm yeah, why no. I can't see what the harm would be -- lets do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants