-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AbstractGP shares array data - impossible to add new points to grid (bayesian optimisation) #385
Comments
It is a known issue and unfortunately something to do with Julia... However for your usecase you can use the following example: |
Hey, thanks a lot for the blazing fast reply. I had a suspicion it was coming from Julia (facepalm...). |
Btw, sorry for going off-topic here, but would you have a suggestion in the 2D case? The actual objective I need to optimise has 2 input variables. I'm not sure how to set up that case. |
Here's a longer explanation of the problem: JuliaGaussianProcesses/KernelFunctions.jl#319 And this is the underlying Julia issue: JuliaLang/julia#33143 |
It should work in the exact same way as the example mentioned before, just keep recomputing the posterior on the new data point you have |
Thanks a lot both of you @theogf and @devmotion . I believe this issue can be closed. |
I'm using AbstractGP to setup a Bayesian Optimisation framework.
However, AbstractGP shares the array used to construct the GP, such that it's impossible to add new points to it (the ones decided by the acquisition function).
Ideally, the steps would be:
Step 6 fails with error "ERROR: cannot resize array with shared data".
The sharing of data happens during step 3.
Steps to reproduce (simplified):
Is this intended? Looks like it's rather limiting the usability in a stragithforward bayesian opt setting.
If this is intended, what would be the correct course of action here?
Should I keep a hard copy of x_test that I update with the new points?
Thanks
The text was updated successfully, but these errors were encountered: