Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize MeanFunction API #356

Closed
simsurace opened this issue Mar 27, 2023 · 2 comments
Closed

Stabilize MeanFunction API #356

simsurace opened this issue Mar 27, 2023 · 2 comments
Assignees
@theogf

Comments

@simsurace
Copy link
Member

It would be nice to have an official API for mean functions. It could be minimalistic for now, but e.g. guarantee that MeanFunction is exported and maybe have a public method meanvector similar to kernelmatrix, that serves as a user-facing version of _map_meanfunction. @theogf

Right now implementing non-standard mean functions requires relying on internals.
@willtebbutt
Copy link
Member

I would be entirely happy to rename _map_meanfunction to meanvector, and to expose it as part of the user-facing API.

A PR which did this, and documented it, would be welcome as far as I'm concerned.

@theogf theogf self-assigned this Mar 28, 2023
@theogf theogf mentioned this issue Mar 28, 2023
Merged
@theogf
Copy link
Member

theogf commented Apr 11, 2023

Solved in #357

@theogf theogf closed this as completed Apr 11, 2023
@martincornejo martincornejo mentioned this issue May 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theogf theogf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@willtebbutt @theogf @simsurace