Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binder setup incorrect #101

Closed
devmotion opened this issue Jan 30, 2021 · 2 comments · Fixed by #120
Closed

Binder setup incorrect #101

devmotion opened this issue Jan 30, 2021 · 2 comments · Fixed by #120

Comments

@devmotion
Copy link
Member

Currently, binder does not recognize that the notebooks use Julia and therefore does not install the correct kernels. It seems Project.toml and Manifest.toml files have to be added in the gh-pages branch (see https://mybinder.readthedocs.io/en/latest/examples/sample_repos.html#julia-binder-demo and fredrikekre/Literate.jl#46 (comment)). If the examples (currently there's only one) require different dependencies, probably it would be helpful to add separate Project.toml + Manifest.toml as suggested in JuliaGaussianProcesses/KernelFunctions.jl#234 (comment).

@devmotion
Copy link
Member Author

Unfortunately, it seems it is not possible to use directories with different project environments (see https://mybinder.readthedocs.io/en/latest/using/config_files.html#project-toml-install-a-julia-environment and jupyterhub/repo2docker#1002). Project.toml (and possibly Manifest.toml) should either be in the root directory of the branch or in a "/binder" subfolder.

@devmotion
Copy link
Member Author

So it seems one has to add one specific set of Project.toml + Manifest.toml files to the root directory of the gh-pages branch. Of course, we could just always copy the current setup in the docs folder (as long as examples don't use their individual environments). However, it seems then always all notebooks, including the ones in the stable subdirectory or the ones in the documentation of previous releases, would use the same project environment. Probably, this will break some of the previous tutorials...

Maybe we should just remove binder links? Or use a different branch for each tutorial?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant