Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bounds on Metal.jl #35

Merged
merged 1 commit into from
Apr 23, 2024
Merged

update bounds on Metal.jl #35

merged 1 commit into from
Apr 23, 2024

Conversation

cpfiffer
Copy link
Contributor

DaggerGPU doesn't have Metal.jl 1.0 permitted in the compat, fixed it.

@jpsamaroo
Copy link
Member

@ronisbr would you be able to validate that tests still pass with Metal 1.x? I no longer have M-series hardware access.

@ronisbr
Copy link
Contributor

ronisbr commented Apr 23, 2024

Hi @jpsamaroo !

I updated Project.toml to allow Metal 1.0, executed the test, and obtained this:

julia> include("runtests.jl")

Test Summary: | Pass  Total  Time
CPU           |    3      3  5.8s
┌ Warning: No CUDA devices available, skipping tests
└ @ Main ~/.julia/dev/DaggerGPU/test/runtests.jl:74
Test Summary: |Time
CUDA          | None  0.1s
┌ Warning: No ROCm devices available, skipping tests
└ @ Main ~/.julia/dev/DaggerGPU/test/runtests.jl:119
Test Summary: |Time
ROCm          | None  0.0s
Test Summary: | Pass  Broken  Total   Time
Metal         |   11       4     15  12.1s
Test.DefaultTestSet("Metal", Any[Test.DefaultTestSet("KernelAbstractions", Any[], 3, false, false, true, 1.713893677632424e9, 1.713893679846801e9, false, "/Users/ronan.arraes/.julia/dev/DaggerGPU/test/runtests.jl"), Test.DefaultTestSet("In-place operations", Any[Test Broken
  Expression: array[1, 1] == 2.0f0, Test Broken
  Expression: array[1, 2] == 3.0f0, Test Broken
  Expression: array[2, 1] == 4.0f0, Test Broken
  Expression: array[2, 2] == 5.0f0], 4, false, false, true, 1.713893679846832e9, 1.713893680416066e9, false, "/Users/ronan.arraes/.julia/dev/DaggerGPU/test/runtests.jl")], 4, false, false, true, 1.713893668300745e9, 1.713893680416068e9, false, "/Users/ronan.arraes/.julia/dev/DaggerGPU/test/runtests.jl")

So everything seems to be working fine!

@jpsamaroo jpsamaroo merged commit 48295d2 into JuliaGPU:master Apr 23, 2024
@jpsamaroo
Copy link
Member

Awesome, thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants