Skip to content
This repository has been archived by the owner on Mar 12, 2021. It is now read-only.

GC preserve in generated ccall #503

Closed
MikeInnes opened this issue Nov 19, 2019 · 1 comment
Closed

GC preserve in generated ccall #503

MikeInnes opened this issue Nov 19, 2019 · 1 comment
Labels
enhancement

Comments

@MikeInnes
Copy link
Collaborator

Since we often pass CuArrays to the low-level wrapper functions, I wonder if it'd make sense to GC.@preserve every input around each generated ccall. Adds some safety and if it is indeed redundant, it should have negligible cost. Any thoughts?
@maleadt
Copy link
Member

maleadt commented Nov 19, 2019

Not necessary: FluxML/Flux.jl#923 (comment)

@maleadt maleadt closed this as completed Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maleadt @MikeInnes