Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsafe_copy3d! requires 2^4 alignment #330

Open
jpsamaroo opened this issue Nov 21, 2022 · 2 comments
Open

unsafe_copy3d! requires 2^4 alignment #330

jpsamaroo opened this issue Nov 21, 2022 · 2 comments
Labels
bug Something isn't working ci

Comments

@jpsamaroo
Copy link
Member

As reported by HSA in CI on master. We should probably switch to a kernel copy for the portions which aren't aligned.

@jpsamaroo jpsamaroo added bug Something isn't working ci labels Nov 21, 2022
@luraess
Copy link
Contributor

luraess commented Apr 4, 2023

Is this still the case? (cc @jpsamaroo @pxl-th) Maybe worth checking as I saw the function got refactored in #374

@pxl-th
Copy link
Member

pxl-th commented Apr 7, 2023

hsa_amd_memory_async_copy_rect accepts hsa_pitched_ptr_s docs for which still say that alignment is required.

We may however, add hsa_amd_memory_async_copy for regular async copy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci
Projects
None yet
Development

No branches or pull requests

3 participants