From 3f526892c9c0b45c92f56a5813303423d84d09ed Mon Sep 17 00:00:00 2001 From: Takafumi Arakaki Date: Mon, 19 Aug 2019 08:53:38 -0700 Subject: [PATCH] Fix bench_gemm.jl performance regression The type parameter of `BottomRF` was changed so `BottomRF{Any}` creates a boxed type. --- benchmark/bench_gemm.jl | 2 +- src/processes.jl | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/benchmark/bench_gemm.jl b/benchmark/bench_gemm.jl index a174da0d32..62f1a061db 100644 --- a/benchmark/bench_gemm.jl +++ b/benchmark/bench_gemm.jl @@ -45,7 +45,7 @@ function xfmul!(C, A, B, simd=Val(false)) c[] = muladd(a, b, c[]) return # for type stability end - transduce(maybe_usesimd(BottomRF{Any}(rf), simd), nothing, CAB) + transduce(maybe_usesimd(BottomRF(rf), simd), nothing, CAB) return C end diff --git a/src/processes.jl b/src/processes.jl index 6e625ba255..bfefb262b1 100644 --- a/src/processes.jl +++ b/src/processes.jl @@ -929,8 +929,7 @@ Base.foreach(eff, ed::Eduction; kwargs...) = transduce(reform(ed.rf, SideEffect(eff)), nothing, ed.coll; kwargs...) Base.foreach(eff, reducible::Reducible; kwargs...) = - transduce(BottomRF{Any}(SideEffect(eff)), nothing, reducible; - kwargs...) + transduce(BottomRF(SideEffect(eff)), nothing, reducible; kwargs...) # Maybe use `__reduce__` in `foreach`? """