-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TV norm prox #124
Comments
I believe it’s not there in the package. Does the prox have closed form? Is it just for 1D signals or also 2D? A PR is of course welcome :-) but let me know in case you need guidance there |
No, the prox is computed iteratively (see the referenced article). I think there is also a 2D version which would be useful for imaging problems I guess, but have not looked at that yet. |
Of course! You can just add a source file in https://github.com/JuliaFirstOrder/ProximalOperators.jl/tree/master/src/functions say named tvnorm.jl and have the function type defined there. You can take a look at other source files there on how to organize it. Only the call and |
Not sure whether you are interested in this, but one could also add some sum of norms, e.g. 1norm+2norm or 1norm+TV. Those are used in Group Lasso or Fused Lasso for example and the proximal operators can be shown to be just the concatenation of the individual proxes (in the right order). |
@fabian-sp do you have references for those? |
1norm + 2norm: Proposition 2.1 in https://arxiv.org/pdf/1712.05910.pdf |
Have you included the prox of the total variation norm, i.e. sum_i |x_i - x_{i-1}|?
I have implemented Condats algorithm in order to compute this (https://lcondat.github.io/publis/Condat-fast_TV-SPL-2013.pdf).
I could share my code.
Cheers!
The text was updated successfully, but these errors were encountered: