-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to hide warnings #25
Comments
I agree in principle, but could you attach a MWE that triggers the warning? Because while hiding the warning we should also (i) make sure that no bug is causing the line search to fail (ii) if no bug is there, make the algorithm's stopping criterion more robust (or line search one, or both). |
Stumbled upon this MWE using StructuredOptimization
using Random
using ProximalAlgorithms: PANOC
using ProximalOperators, AbstractOperators
using RecursiveArrayTools
Random.seed!(13)
n,m = 10,20
Y = randn(n,m)
A = [Eye(size(Y)) Eye(size(Y))]
x0 = ArrayPartition(zeros(size(Y)), zeros(size(Y)))
f = PrecomposeDiagonal(SqrNormL2(), 1.0, Y)
g1 = NormL1()
g2 = IndBallRank(2)
g = SeparableSum(g2,g1)
solver = PANOC(verbose=true)
solver(x0; f=f, A=A, g=g) maybe there's something simpler but better then nothing for the moment! |
On Julia 1.1.1 I get an even stranger behaviour:
i.e., the warning is actually a lie! (The iteration continues somehow) Looking into it. |
Yes, I forgot to mention that I'm in Julia 1.1.1! |
Seems like a weird bug (and a hard one to reproduce): changing the last two lines in the MWE to solver = PANOC(verbose=true, freq=1)
solver(x0; f=f, A=A, g=g) then the iterations do stop as expected:
|
Very strange!! We should check in Julia 1.2.. but I'm not going to update yet (waiting next week) |
Seems in the latest version the MWE below doesn't raise any warnings!
|
I’m closing this, since using |
Should be easy to implement?
For example in PANOC
I would also default it to
warnings=false
.The text was updated successfully, but these errors were encountered: