Document GITHUB_TOKEN workaround #1239
Conversation
| for more information. | ||
| While GitHub will automatically create a github token for you named "GITHUB_TOKEN", | ||
| it will not have push access. Therefore, you must override | ||
| GitHub by making a new personal access token with the same name. |
There was a problem hiding this comment.
It should specifically say what to do.
There was a problem hiding this comment.
I can add a note like (see instructions above) because I did add instructions to do this?
There was a problem hiding this comment.
Yes, and a link to that part of the instructions
|
I also think more adjustment to the documentation is needed based on what I said here: |
|
Now that github actions is up and running maybe we should just ditch all the travis and ssh-key docs? |
I agree. Probably it is better to move them to a separate document called |
|
IMO we should not Document this option and only recommend SSH keys (as we already do). |
|
Why? |
|
Because access tokens are not limited to one repo, and is tied to a user, so it would be like giving your github password to everyone with write access to the repo in question. |
|
Hmm I think I see what your saying. Still seems like a pain to make SSH keys for each individual repo. I wonder if there's another solution? |
|
You can reuse it if you want |
|
I have to agree with @fredrikekre here: we shouldn't recommend the use of personal access tokens for this.
I don't think this is true. If you try to add the same deploy key again, GitHub will complain if I remember correctly.
As long as we don't have #1177, we can't ditch the deploy key stuff. We could have GitHub Actions as the recommended setup (even as we're waiting for #1177), but no reason to ditch Travis -- it can still be useful for some people. |
|
Close in favor of #1244 |
Closes #1177