-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incomplete at-docs block #928
Conversation
3ba7e72
to
69da6e2
Compare
Big 👍 to including the docstrings that are possible to include. However, now there is nothing about the failed ones in the generated output, which I think makes them easy to miss (unless you do strict builds). So I would still output something for the failed docstrings too. Could we maybe just push a generated |
also fixes #474 |
dd823c6
to
af55eab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome!
Have you tested it with all the output formats, to make sure all handle the updated DocsNodes
correctly? It might be good to have a test case in test/examples
too (although, we might inadvertently already do).
faee5d4
to
cfe5a80
Compare
Yes.
Exists at the top of https://github.com/JuliaDocs/Documenter.jl/blob/91fc140e7adef2eb17b85d8a2848e805877062ba/test/errors/src/index.md. |
Include working doc strings instead of bailing completely in at-docs block.
Fix #799